-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Adds local mender-configure artifacts generation #2219
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor corrections from me. I'm approving now so you can merge immediately after fixing.
Hello folks, I added a new part of "signed mender-configure" artifacts. Can any of you give me your blessing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
09.Add-ons/10.Configure/docs.md
Outdated
|
||
### Prerequisite | ||
|
||
You will need an script already localted in `/usr/lib/mender-configure/apply-device-config.d` as described in ["How to make an apply-device-config script"](01.Device-integration/docs.md#how-to-write-an-apply-device-config-script) section of these docs. | ||
You will need a script already localted in `/usr/lib/mender-configure/apply-device-config.d` as described in ["How to make an apply-device-config script"](01.Device-integration/docs.md#how-to-write-an-apply-device-config-script) section of these docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localted
-> located
09.Add-ons/10.Configure/docs.md
Outdated
|
||
#### Handle signed Artifacts | ||
|
||
You can take advantage of this approach to handle signed artifacts as you can include signatures from your workstation as opposed by using the Mender Configure UI per device to deploy a configuration. Just generate they key and add the `-k private.key` flag into the previous command as described in the [Artifact Signing section](../../06.Artifact-creation/07.Sign-and-verify/docs.md#signing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...generate the key..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
One thing that is missing is how will the UI behave once you deploy the configuration this way.
The reason why this isn't fully equivalent to using the UI is that this way only the reported
(of the configuration API get changed while the configure
remains the same.
If you use the API the configured
changes first and that triggers the generation of the new update.
You should confirm that the UI will function normally after using this apprach and document that.
77fac55
to
bf951dc
Compare
…figure sign process Signed-off-by: Luis Ramirez Vargas <[email protected]>
bf951dc
to
80a9798
Compare
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff
. Also note that the signoff author must match the author of the commit.Description
Please describe your pull request.
Thank you!