-
Notifications
You must be signed in to change notification settings - Fork 23
[master < T945] Add periodic iterate docs #945
Conversation
mage/query-modules/cpp/periodic.md
Outdated
:::caution | ||
This module breaks the isolation levels in the database, as the results are batched and executed in different transactions. Do | ||
not consider the query which executes this procedure to be aligned with set isolation level of the database, as every executed batch | ||
is committed by itself. An issue while running this procedure will not result in rollbacking batches of committed results. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true for the whole query or just this procedure? Consider moving this to the introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one procedure here. So I'd say both hold true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are currently no plans to expand this module with more procedures, i would just write the whole warning in the intro if that's ok with you :) (i can do it, just give me the thumbs up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave myself a thumbs up :D if it's a problem i'll chang it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some lang changes + a Q about the warning
Co-authored-by: Vlasta <[email protected]>
Co-authored-by: Vlasta <[email protected]>
…nto feature/periodic-iterate
Description
This is a new query module which helps users executed difficult and complex queries by batching results of one query into another.
Pull request type
Please delete options that are not relevant and check the ones that are.
Checklist: