This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[master < T945] Add periodic iterate docs #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josipmrden
changed the title
vpavicic
added
status: ready
vpavicic
reviewed
Jun 28, 2023
vpavicic
reviewed
Jun 28, 2023
mage/query-modules/cpp/periodic.md
Outdated
Comment on lines
40
to
44
| :::caution | ||
| This module breaks the isolation levels in the database, as the results are batched and executed in different transactions. Do | ||
| not consider the query which executes this procedure to be aligned with set isolation level of the database, as every executed batch | ||
| is committed by itself. An issue while running this procedure will not result in rollbacking batches of committed results. | ||
| ::: |
There was a problem hiding this comment.
Is this true for the whole query or just this procedure? Consider moving this to the introduction
There was a problem hiding this comment.
There is only one procedure here. So I'd say both hold true
There was a problem hiding this comment.
If there are currently no plans to expand this module with more procedures, i would just write the whole warning in the intro if that's ok with you :) (i can do it, just give me the thumbs up)
There was a problem hiding this comment.
I gave myself a thumbs up :D if it's a problem i'll chang it back
vpavicic
reviewed
Jun 28, 2023
vpavicic
reviewed
Jun 28, 2023
vpavicic
added
status: change
vpavicic
suggested changes
Jun 28, 2023
Co-authored-by: Vlasta <[email protected]>
Co-authored-by: Vlasta <[email protected]>
…nto feature/periodic-iterate
vpavicic
approved these changes
Jun 28, 2023
vpavicic
added
status: ship it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new query module which helps users executed difficult and complex queries by batching results of one query into another.
Pull request type
Please delete options that are not relevant and check the ones that are.
Checklist: