-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use uv in tap, target and mapper templates #2859
Conversation
Reviewer's Guide by SourceryThis pull request migrates the cookiecutter templates to use uv instead of poetry for dependency management and build tooling. This includes changes to the pyproject.toml files, the github workflows, the README files, the pre-commit configuration, and the noxfile. Flow diagram: Updated development workflow with UVflowchart TD
start["Start Development"]
install["Install UV"]
sync["uv sync"]
test["uv run pytest"]
build["uv build"]
check["twine check dist/*"]
start --> install
install --> sync
sync --> test
test --> build
build --> check
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 62 62
Lines 5209 5209
Branches 673 673
=======================================
Hits 4758 4758
Misses 319 319
Partials 132 132 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #2859 will not alter performanceComparing Summary
|
a8145cd
to
40fda8e
Compare
40fda8e
to
7bbd2d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<!-- Please, go through these steps when you submit a PR. 1. Make sure your branch is not protected. In particular, avoid making PRs from the `main` branch of your fork. 2. Give a descriptive title to your PR. We use semantic titles, and the accepted types and scopes are listed in https://github.com/meltano/meltano/blob/main/.github/semantic.yml. A good title should look like this: ``` feat(cli): The `meltano run` command now accepts a `--timeout` option to limit the time it runs ``` 3. Provide a description of your changes. 4. Put "Closes #XXXX" in your comment to auto-close the issue that your PR fixes (if such). --> ## Description <!-- Describe the changes introduced by this PR --> The SDK templates now use uv. - https://deploy-preview-9069--meltano.netlify.app/guide/debugging-custom-extractor - https://deploy-preview-9069--meltano.netlify.app/tutorials/custom-extractor/ ## Related Issues * meltano/sdk#2859
Related
Summary by Sourcery
Build:
hatchling
instead ofpoetry
.📚 Documentation preview 📚: https://meltano-sdk--2859.org.readthedocs.build/en/2859/
Summary by Sourcery
Switch from Poetry to Hatchling for project management and builds.
Build:
hatchling
instead ofpoetry
.CI:
uv
instead ofpoetry
and addtwine
for checking distribution builds.Documentation:
Tests:
uv run
instead ofpoetry run
.