Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taps,targets): Support the singer.decimal JSON Schema extension #2786

Draft
wants to merge 9 commits into
base: edgarrmondragon/refactor/jsonschematosql-fromconfig
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 30, 2024

TODO:

  • Docs
  • Capability/Built-in setting

Related:


📚 Documentation preview 📚: https://meltano-sdk--2786.org.readthedocs.build/en/2786/

@edgarrmondragon edgarrmondragon added SQL Support for SQL taps and targets Type/Target Singer targets Type/Tap Singer taps labels Nov 30, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 30, 2024
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (7a386c9) to head (6ec48ae).

Additional details and impacted files
@@                                   Coverage Diff                                   @@
##           edgarrmondragon/refactor/jsonschematosql-fromconfig    #2786      +/-   ##
=======================================================================================
+ Coverage                                                91.34%   91.35%   +0.01%     
=======================================================================================
  Files                                                       62       62              
  Lines                                                     5210     5218       +8     
  Branches                                                   672      673       +1     
=======================================================================================
+ Hits                                                      4759     4767       +8     
  Misses                                                     319      319              
  Partials                                                   132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #2786 will not alter performance

Comparing edgarrmondragon/feat/singer-decimal (6ec48ae) with edgarrmondragon/refactor/jsonschematosql-fromconfig (7a386c9)

Summary

✅ 7 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch from de53f85 to 42a702d Compare November 30, 2024 20:27
@s7clarke10
Copy link
Contributor

That's awesome, thanks once again @edgarrmondragon 🙌

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-decimal branch from ff67a40 to 8e95d23 Compare January 29, 2025 15:20
@edgarrmondragon edgarrmondragon added this to the v0.45 milestone Jan 29, 2025
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-decimal branch from e27b663 to 9df828b Compare January 30, 2025 00:38
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/singer-decimal branch from 584d3b5 to 6ec48ae Compare January 30, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL Support for SQL taps and targets Type/Tap Singer taps Type/Target Singer targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants