Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some redundant calls to typing.cast #2077

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 29, 2023

Copy link

codspeed-hq bot commented Nov 29, 2023

CodSpeed Performance Report

Merging #2077 will not alter performance

Comparing edgarrmondragon/chore/remove-some-redundant-typing-casts (e5b49d0) with main (a2cdfe8)

Summary

✅ 4 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/chore/remove-some-redundant-typing-casts branch from bebd403 to e5b49d0 Compare November 29, 2023 22:59
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2cdfe8) 87.65% compared to head (e5b49d0) 87.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.01%     
==========================================
  Files          60       60              
  Lines        4940     4939       -1     
  Branches     1006     1006              
==========================================
- Hits         4330     4329       -1     
  Misses        429      429              
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 29, 2023 23:05
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners November 29, 2023 23:05
@edgarrmondragon edgarrmondragon merged commit 34027f9 into main Nov 29, 2023
27 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/chore/remove-some-redundant-typing-casts branch November 29, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant