Modify modifier apply functions to remove stmtExprs #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @TravisCarlson, care to take a look at some point? |
My comments are under #147. Do we still want to apply this pull request? From the last comments it looks like we were going to look into a different solution. Has anything changed since then? |
|
Thanks Travis, I had forgotten about that discussion. @counc009 is it OK to close this? |
|
Yeah, I'm fine closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses initial suggestion in #147, removes use of stmtExpr so that qualifier mods can still result in lValues necessary for many productions.