Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose image load events and bind responders #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

expose image load events and bind responders #71

wants to merge 1 commit into from

Conversation

alxyuu
Copy link

@alxyuu alxyuu commented Feb 27, 2018

  • re-expose load events through gallery (all props were originally passed through in ldn0x7dc's implementation)
  • bind responders so TransformableImage can be used directly, they were resolving to the wrong scope when using outside of Gallery
  • show error state in the edge case where the dimensions load but the image does not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alxyuu