generated JS: add space before while loop condition (#1297)

* generated JS: add space before while loop condition * snapshot runtime tests * fix blackbox tests * chore: add changelog entry
melange-re · Jan 14, 2025 · b52efa7 · b52efa7
1 parent 8ec534d
commit b52efa7
Show file tree

Hide file tree

Showing 92 changed files with 976 additions and 972 deletions.
diff --git a/Changes.md b/Changes.md
@@ -97,6 +97,8 @@ Unreleased
   ([#1295](https://github.com/melange-re/melange/pull/1295))
 - JS generation: move space before comma inside `for` definition
   ([#1296](https://github.com/melange-re/melange/pull/1296))
+- JS generation: add space before while loop condition
+  ([#1297](https://github.com/melange-re/melange/pull/1297))
 
 4.0.1 2024-06-07
 ---------------

diff --git a/jscomp/core/js_dump.ml b/jscomp/core/js_dump.ml
@@ -1071,13 +1071,15 @@ and statement_desc top cxt (s : J.statement_desc) : cxt =
         match e.expression_desc with
         | Number (Int { i = 1l; _ }) ->
             string cxt L.while_;
+            space cxt;
             string cxt L.lparen;
             string cxt L.true_;
             string cxt L.rparen;
             space cxt;
             cxt
         | _ ->
             string cxt L.while_;
+            space cxt;
             let cxt = paren_group cxt 1 (fun () -> expression ~level:0 cxt e) in
             space cxt;
             cxt

diff --git a/jscomp/test/dist/jscomp/test/a_scope_bug.js b/jscomp/test/dist/jscomp/test/a_scope_bug.js
diff --git a/jscomp/test/dist/jscomp/test/and_or_tailcall_test.js b/jscomp/test/dist/jscomp/test/and_or_tailcall_test.js
diff --git a/jscomp/test/dist/jscomp/test/app_root_finder.js b/jscomp/test/dist/jscomp/test/app_root_finder.js
diff --git a/jscomp/test/dist/jscomp/test/arith_lexer.js b/jscomp/test/dist/jscomp/test/arith_lexer.js
diff --git a/jscomp/test/dist/jscomp/test/array_subtle_test.js b/jscomp/test/dist/jscomp/test/array_subtle_test.js
diff --git a/jscomp/test/dist/jscomp/test/array_test.js b/jscomp/test/dist/jscomp/test/array_test.js
diff --git a/jscomp/test/dist/jscomp/test/ast_js_mapper_test.js b/jscomp/test/dist/jscomp/test/ast_js_mapper_test.js
diff --git a/jscomp/test/dist/jscomp/test/bal_set_mini.js b/jscomp/test/dist/jscomp/test/bal_set_mini.js
diff --git a/jscomp/test/dist/jscomp/test/bdd.js b/jscomp/test/dist/jscomp/test/bdd.js
diff --git a/jscomp/test/dist/jscomp/test/bs_stack_test.js b/jscomp/test/dist/jscomp/test/bs_stack_test.js
diff --git a/jscomp/test/dist/jscomp/test/class6_test.js b/jscomp/test/dist/jscomp/test/class6_test.js
diff --git a/jscomp/test/dist/jscomp/test/class7_test.js b/jscomp/test/dist/jscomp/test/class7_test.js
diff --git a/jscomp/test/dist/jscomp/test/complex_while_loop.js b/jscomp/test/dist/jscomp/test/complex_while_loop.js
diff --git a/jscomp/test/dist/jscomp/test/cps_test.js b/jscomp/test/dist/jscomp/test/cps_test.js
diff --git a/jscomp/test/dist/jscomp/test/demo_int_map.js b/jscomp/test/dist/jscomp/test/demo_int_map.js
diff --git a/jscomp/test/dist/jscomp/test/exception_raise_test.js b/jscomp/test/dist/jscomp/test/exception_raise_test.js
diff --git a/jscomp/test/dist/jscomp/test/ext_array_test.js b/jscomp/test/dist/jscomp/test/ext_array_test.js