Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OCL version from 1.2.9 to 2.4.0 #283

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

alaboso
Copy link
Contributor

@alaboso alaboso commented Oct 7, 2024

Description of what I changed

  1. Updated pom.xml openconceptlabVersion from 1.2.9. to 2.4.0
  2. Updated api/src/test/resources/testAppDataDir/configuration/ocl/test.zip - New version from OCL with self-mappings added in OCL by OCL itself instead of by the openmrs-module-openconceptlab
  3. Updated OpenmrsProfile in OpenConceptLabLoader
  4. OpenConceptLabLoaderIntegrationTest concept names which have since been updated in OCL. (uppercase to lowercase and other concept names added/removed)
  5. Updated openconceptlab module version in DomainBaseModuleContextSensitiveTest

Issue I worked on

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    Ran: mvn --batch-mode --update-snapshots clean package -P validator

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

Copy link
Member

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alaboso. Generally LGTM. I have one little concern to address below.

README.md Outdated Show resolved Hide resolved
…ated README runtime compatibility revert to 1.2.9
@Ruhanga Ruhanga merged commit 714ca3e into mekomsolutions:main Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants