Support oxygen tank filling for Electrolytic Breathing Unit #8321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiakil
reviewed
Jan 28, 2025
| } | ||
|
|
||
| private long produceOxygen(Player player, int maxRate) { | ||
| if (!fillOxygen) { |
There was a problem hiding this comment.
this needs to be made clear to the user (that toggling it on will stop the breathing benefit)
There was a problem hiding this comment.
@thiakil I changed the names to Fill Hydrogen and Fill Oxygen (Disables Feeder). Not too sure about these. Open to feedback.
- Add config "Fill Hydrogen" & "Fill Oxygen (Disables Feeder)"
bukowski912
force-pushed
the
electrolytic-oxygen-tank
branch
from
d4e522b to
c2c09fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: