Skip to content

Commit

Permalink
fix #112: Remove the useless headless option
Browse files Browse the repository at this point in the history
  • Loading branch information
qdequele committed Nov 9, 2024
1 parent 536326a commit ad970e6
Show file tree
Hide file tree
Showing 3 changed files with 376 additions and 27 deletions.
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ data:
"meilisearch_api_key": "masterKey",
"meilisearch_index_uid": "google",
"strategy": "default", // docssearch, schema*, custom, markdown or default
"headless": true, // Use headless browser for rendering javascript websites
"batch_size": 1000, // pass null to send documents 1 at a time or specify a batch size
"primary_key": null,
"meilisearch_settings": {
Expand Down Expand Up @@ -165,10 +164,6 @@ Name of the index on which the content is indexed.
default: `default`
Scraping strategy: - `default` Scrapes the content of webpages, it is suitable for most use cases. It indexes the content in this format (show example) - `docssearch` Scrapes the content of webpages, it suits most use cases. The difference with the default strategy is that it indexes the content in a format compatible with docs-search bar - `schema` Scraps the [`schema`](https://schema.org/) information of your web app.

`headless`
default: `true`
Wether or not the javascript should be loaded before scraping starts.

`primary_key`
The key name in your documents containing their unique identifier.

Expand Down
2 changes: 1 addition & 1 deletion src/crawlers/puppeteer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class PuppeteerCrawler extends BaseCrawler {
}),
launchContext: {
launchOptions: {
headless: this.config.headless || true,
headless: true,
args: ["--no-sandbox", "--disable-setuid-sandbox"],
ignoreDefaultArgs: ["--disable-extensions"],
...this.launchOptions,
Expand Down
Loading

0 comments on commit ad970e6

Please sign in to comment.