Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support searchCutoffMs setting #588

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

JWSong
Copy link
Contributor

@JWSong JWSong commented Jun 29, 2024

Pull Request

Related issue

Fixes #581

What does this PR do?

  • support searchCutoffMs setting

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, that’s perfect @JWSong.
Thanks a lot!

bors merge

Copy link
Contributor

meili-bors bot commented Jul 1, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 9443600 into meilisearch:main Jul 1, 2024
7 checks passed
@curquiza curquiza added the enhancement New feature or request label Jul 1, 2024
meili-bors bot added a commit that referenced this pull request Jul 1, 2024
591: Fix .code-samples.meilisearch.yaml r=irevoire a=curquiza

Following wrong implementation in #588

Co-authored-by: Clémentine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.8] Support searchCutoffMs setting
3 participants