Support batching and updating with JSON, NDJSON, and CSV #599
+292
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, this was only done for http_post as a workaround to allow disabling the automatic JSON conversion of "body" to support CSV, NDJSON, and possible other future payload types. This must be done for at least http_put at least, since there are update_* methods to go along with the add_* methods for the various payload types. I added the option to all of the http methods to prevent any future surprises.
Previously, you could only *replace* documents with the add endpoints.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 749 780 +31
=========================================
+ Hits 749 780 +31 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #243
The issue is very old, I added what I saw was missing in it, hopefully now we can close it. Reviewing can be done commit-by-commit, might be easier to follow.