Add methods for new index settings: facetSearch and prefixSearch
#1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thicolares
force-pushed
the
add-new-index-settings-facetSearch-prefixSearch
branch
from
f144123 to
49cba4a
Compare
Required for facet-search settings and possibly others.
thicolares
force-pushed
the
add-new-index-settings-facetSearch-prefixSearch
branch
from
49cba4a to
cdbbdc1
Compare
thicolares
commented
Jan 25, 2025
| @@ -64,7 +65,7 @@ def send_request( | |||
| serialize_body = isinstance(body, dict) or body | |||
| data = ( | |||
| json.dumps(body, cls=serializer) | |||
| if serialize_body | |||
| if isinstance(body, bool) or serialize_body | |||
There was a problem hiding this comment.
I believe these nested ifs are bit convoluted. But I decided not revamping them now :) Previous PRs suggest it might be for backward compatibility
thicolares
commented
Jan 25, 2025
There was a problem hiding this comment.
Note inconsistency: get_facet_search_settings (note the _settings suffix) x get_prefix_search. Is there a reason for that? I left as is for consistency with existing implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1048
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!