Make key description optional #1067
Conversation
| @@ -46,6 +46,15 @@ def test_create_keys_default(client, test_key_info): | |||
| assert key.indexes == test_key_info["indexes"] | |||
|
|
|||
|
|
|||
| def test_create_keys_without_desc(client, test_nondescript_key_info): | |||
There was a problem hiding this comment.
I did confirm it breaks without the change in the non-test code.
| @@ -206,6 +206,27 @@ def test_key_info(client): | |||
| pass | |||
|
|
|||
|
|
|||
| @fixture(scope="function") | |||
| def test_nondescript_key_info(client): | |||
There was a problem hiding this comment.
I don't think this is really necessary, I didn't just change the test_key_info since that seemed a bit intrusive.
The reason why test_key_info would not work is because it uses descriptions to identify the keys that it created, which of course is a problem if the descriptions are None.
I think it would probably be best to delete this function and update the original one to use created_at, or just use the fact that the most recently created key should be first:
NOTE
API keys are displayed in descending order based on their createdAt date. This means that the most recently created keys appear first.
https://www.meilisearch.com/docs/reference/api/keys#get-all-keys
Fixes #1038