Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a base exception interface all exceptions must implement #534

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Add a base exception interface all exceptions must implement #534

merged 3 commits into from
Jul 28, 2023

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Jun 25, 2023 •
edited
Loading

Pull Request

What does this PR do?

  • Add a base exception interface all exceptions must implement
  • via symfony (perhaps will open a PR in the bundle), I need to listen on Meilisearch exceptions, adding this interface ease the process of subscriber to kernel exception

for ex in the doc with $exception instanceof HttpExceptionInterface

here we will be able to hook into Meilisearch\Exceptions\ExceptionInterface

Please feel free to challenge/discuss, thanks!

@brunoocasali
Copy link
Member

bors merge

@brunoocasali brunoocasali added the enhancement New feature or request label Jul 27, 2023
meili-bors bot added a commit that referenced this pull request Jul 27, 2023
@meili-bors @94noni @dependabot
Merge #534 #555
692be01 
534: Add a base exception interface all exceptions must implement r=brunoocasali a=94noni

# Pull Request

## What does this PR do?
- Add a base exception interface all exceptions must implement
- via symfony (perhaps will open a PR in the bundle), I need to listen on Meilisearch exceptions, adding this interface ease the process of subscriber to kernel exception

for ex in [the doc ](https://symfony.com/doc/current/event_dispatcher.html#creating-an-event-listener) with `$exception instanceof HttpExceptionInterface`

here we will be able to hook into `Meilisearch\Exceptions\ExceptionInterface`

---

Please feel free to challenge/discuss, thanks!

555: Update phpstan/phpstan requirement from 1.10.25 to 1.10.26 r=brunoocasali a=dependabot[bot]

Updates the requirements on [phpstan/phpstan](https://github.com/phpstan/phpstan) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/phpstan/phpstan/releases">phpstan/phpstan's releases</a>.</em></p>
<blockquote>
<h2>1.10.26</h2>
<h1>Improvements 🔧</h1>
<ul>
<li>More precise return type for trigger_error (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2526">#2526</a>), thanks <a href="https://github.com/paulbalandan"><code>`@​paulbalandan</code></a>!</li>`
</ul>
<h1>Bugfixes 🐛</h1>
<ul>
<li>Fix filtering default stub files on Windows (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2406">#2406</a>), thanks <a href="https://github.com/maryo"><code>`@​maryo</code></a>!</li>`
<li>FileHelper absolutize and normalize: Fix path with scheme (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2506">#2506</a>), thanks <a href="https://github.com/mvorisek"><code>`@​mvorisek</code></a>!</li>`
<li>Fix <code>array_keys()</code> and `array_values()`` on constant arrays (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2516">#2516</a>), thanks <a href="https://github.com/jlherren"><code>`@​jlherren</code></a>!</li>`
<li>Fix access to uninitialized property via extension in additional constructor (<a href="https://github.com/phpstan/phpstan-src/commit/218aad0804bebd8f0ad60eea69afb24d8fa4ca48">https://github.com/phpstan/phpstan-src/commit/218aad0804bebd8f0ad60eea69afb24d8fa4ca48</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9619">#9619</a></li>
<li>Fix result cache bug with imported type aliases (<a href="https://github.com/phpstan/phpstan-src/commit/553c4b141b62244f629b22fe7e8054196cd73a58">https://github.com/phpstan/phpstan-src/commit/553c4b141b62244f629b22fe7e8054196cd73a58</a>), <a href="https://redirect.github.com/phpstan/phpstan/issues/9622">#9622</a></li>
<li>Fix result cache bug with imported type aliases in a trait (<a href="https://github.com/phpstan/phpstan-src/commit/d8071d0904e4b06a814a0b8b8d7f343d72db0633">https://github.com/phpstan/phpstan-src/commit/d8071d0904e4b06a814a0b8b8d7f343d72db0633</a>)</li>
<li>Fix PHP 8.3 deprecation (<code>$foo--</code> with a non-numeric string no longer allowed) (<a href="https://github.com/phpstan/phpstan-src/commit/c6f4c4ceb7d7355ef761a6ffaa1b1574469789c6">https://github.com/phpstan/phpstan-src/commit/c6f4c4ceb7d7355ef761a6ffaa1b1574469789c6</a>)</li>
<li>Array shape with optional keys might be a list (<a href="https://github.com/phpstan/phpstan-src/commit/97f0039fe568eec83607861c36718e8f79c481ff">https://github.com/phpstan/phpstan-src/commit/97f0039fe568eec83607861c36718e8f79c481ff</a>)</li>
<li>ArrayMapFunctionReturnTypeExtension - preserve array being a list (<a href="https://github.com/phpstan/phpstan-src/commit/d55c4f2c207a6a07712cff2cdaba670fee950258">https://github.com/phpstan/phpstan-src/commit/d55c4f2c207a6a07712cff2cdaba670fee950258</a>)</li>
</ul>
<h1>Function signature fixes 🤖</h1>
<ul>
<li>More precise <code>ftp_*</code> mode parameter type (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2513">#2513</a>), thanks <a href="https://github.com/staabm"><code>`@​staabm</code></a>!</li>`
<li>Fix signature of <code>DOMNode::lookupNamespaceURI</code> (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2527">#2527</a>), thanks <a href="https://github.com/paulbalandan"><code>`@​paulbalandan</code></a>!</li>`
</ul>
<h1>Internals 🔍</h1>
<ul>
<li>Simplify access to class reflections in InClassNode rules (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2514">#2514</a>), thanks <a href="https://github.com/mad-briller"><code>`@​mad-briller</code></a>!</li>`
<li>Simplify access to class reflections in ClassPropertiesNode (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2520">#2520</a>), thanks <a href="https://github.com/mad-briller"><code>`@​mad-briller</code></a>!</li>`
<li>Simplify access to function reflection in FunctionReturnStatementsNode rules (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2522">#2522</a>), thanks <a href="https://github.com/mad-briller"><code>`@​mad-briller</code></a>!</li>`
<li>Set class and method reflection in the MethodReturnStatementNode (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2515">#2515</a>), thanks <a href="https://github.com/mad-briller"><code>`@​mad-briller</code></a>!</li>`
<li>Simplify access to class reflections in ClassConstantsNode and ClassMethodsNode rules (<a href="https://redirect.github.com/phpstan/phpstan-src/pull/2521">#2521</a>), thanks <a href="https://github.com/mad-briller"><code>`@​mad-briller</code></a>!</li>`
<li>Introduce InTraitNode (<a href="https://github.com/phpstan/phpstan-src/commit/657fc54b7d358622b791828f94a6a6d9d0f8207c">https://github.com/phpstan/phpstan-src/commit/657fc54b7d358622b791828f94a6a6d9d0f8207c</a>)</li>
<li>TrinaryLogic for <code>isList</code> in ConstantArrayType (<a href="https://github.com/phpstan/phpstan-src/commit/158c61c6777acb416fb5ff243916c1483b0f220a">https://github.com/phpstan/phpstan-src/commit/158c61c6777acb416fb5ff243916c1483b0f220a</a>, <a href="https://github.com/phpstan/phpstan-src/commit/f0a9fd796e1b1d023affdb7fb4ffd344d79becd4">https://github.com/phpstan/phpstan-src/commit/f0a9fd796e1b1d023affdb7fb4ffd344d79becd4</a>)</li>
<li>Add polyfill for PHP 8.1 (<a href="https://github.com/phpstan/phpstan-src/commit/a8818be2f31d2bc33ac6ccb3c3f221248e70a514">https://github.com/phpstan/phpstan-src/commit/a8818be2f31d2bc33ac6ccb3c3f221248e70a514</a>, <a href="https://github.com/phpstan/phpstan-src/commit/cda7e69587a3d46afe098bf7657af364f3980356">https://github.com/phpstan/phpstan-src/commit/cda7e69587a3d46afe098bf7657af364f3980356</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/phpstan/phpstan/commit/5d660cbb7e1b89253a47147ae44044f49832351f"><code>5d660cb</code></a> PHPStan 1.10.26</li>
<li><a href="https://github.com/phpstan/phpstan/commit/d55c4f27a61c84ef4a0456201273f12b852644cd"><code>d55c4f2</code></a> Updated PHPStan to commit d55c4f2c207a6a07712cff2cdaba670fee950258</li>
<li><a href="https://github.com/phpstan/phpstan/commit/97f00390adf84bd79b50d77cea6bb5078f2b117e"><code>97f0039</code></a> Updated PHPStan to commit 97f0039fe568eec83607861c36718e8f79c481ff</li>
<li><a href="https://github.com/phpstan/phpstan/commit/b71aa347b6414520d120170547d523caf8545e8d"><code>b71aa34</code></a> Updated PHPStan to commit b71aa34e6a36b6a32f61c7982ab2232bbd59bcff</li>
<li><a href="https://github.com/phpstan/phpstan/commit/f0a9fd7eb559699a0dbeb776e365d36b1f88bccd"><code>f0a9fd7</code></a> Updated PHPStan to commit f0a9fd796e1b1d023affdb7fb4ffd344d79becd4</li>
<li><a href="https://github.com/phpstan/phpstan/commit/a8818bed8e3236deae64a1ec3313e9ac26ab66cd"><code>a8818be</code></a> Updated PHPStan to commit a8818be2f31d2bc33ac6ccb3c3f221248e70a514</li>
<li><a href="https://github.com/phpstan/phpstan/commit/158c61ce95e1c7390b79b2b39c95a6d85908b5c2"><code>158c61c</code></a> Updated PHPStan to commit 158c61c6777acb416fb5ff243916c1483b0f220a</li>
<li><a href="https://github.com/phpstan/phpstan/commit/0bb14968db78dcecc2523e2d540ec45926040564"><code>0bb1496</code></a> Updated PHPStan to commit 0bb149618b0f81bce5264b94c89ea9de895287fb</li>
<li><a href="https://github.com/phpstan/phpstan/commit/c6f4c4c87544287e501df26ffcab4761687a08cd"><code>c6f4c4c</code></a> Updated PHPStan to commit c6f4c4ceb7d7355ef761a6ffaa1b1574469789c6</li>
<li><a href="https://github.com/phpstan/phpstan/commit/d22a9f1db0ec14858eba6622c8f0a52b67f14485"><code>d22a9f1</code></a> Updated PHPStan to commit d22a9f1f8175badf1c1c857783583ee8f64f3bfe</li>
<li>Additional commits viewable in <a href="https://github.com/phpstan/phpstan/compare/1.10.25...1.10.26">compare view</a></li>
</ul>
</details>
<br />


You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: Antoine Makdessi <[email protected]>
Co-authored-by: Antoine M <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 27, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@brunoocasali
Copy link
Member

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 28, 2023

Build succeeded:

@94noni 94noni closed this Jul 28, 2023
@meili-bors meili-bors bot merged commit 4df0edb into meilisearch:main Jul 28, 2023
8 checks passed
@94noni 94noni deleted the base-ex branch July 28, 2023 12:38
@94noni
Copy link
Contributor Author

94noni commented Jul 28, 2023

thx a lot!

@brunoocasali brunoocasali mentioned this pull request Jul 31, 2023
Merged
meili-bors bot added a commit that referenced this pull request Jul 31, 2023
@meili-bors @meili-bot
Merge #557
ba2756a 
557: Update version for the next release (v1.3.0) r=brunoocasali a=meili-bot

This version introduces features released on Meilisearch v1.3.0 🎉
Check out the changelog of [Meilisearch v1.3.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.3.0) for more information on the changes. 

⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version.

## 🚀 Enhancements

* Add a base exception interface all exceptions must implement (#534) `@94noni`
* ⚠️ **EXPERIMENTAL**: `setShowRankingScoreDetails` and `search(['showRankingScoreDetails' => boolean])` to show the scores of each relevant document returned in the search.
* ⚠️ **EXPERIMENTAL**: `setVector` and `search(['vector' => [...]])` to enable vector search capabilities.
* Add `setAttributesToSearchOn` and `search(['attributesToSearchOn' => [...]])`
* `index->facetSearch(FacetSearchQuery params)` to search only in facets.

⚠️ The EXPERIMENTAL features are not covered by semver. To explicitly opt-in, check this [guide](https://www.meilisearch.com/docs/reference/api/experimental-features).

## 💅 Misc

* Migrate docs hosting to Meilisearch subdomain (#553) `@Strift`
* Update SDK docs link in README.md (#556) `@Strift`
* [DX] Improve quality of Client class & related (#514) `@stloyd`
* [DX] Add support for PHPUnit 10.1 (#516) `@stloyd`

Thanks again to `@94noni,` `@Strift,` `@alallema,` `@brunoocasali,` `@norkunas` and `@stloyd!` 🎉


Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@94noni @brunoocasali @norkunas