-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make replicas have 1 hardcoded #193
Make replicas have 1 hardcoded #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me @alallema
@meilisearch sync-manifest |
1 similar comment
@meilisearch sync-manifest |
@brunoocasali it seems the sync-manifest command is erroring with the following error: |
Yes, it's possible that the GitHub action doesn't work correctly for people who don't have rights on the repo. Sorry about that I allow myself to update the manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @damieneichhorn for this PR!
LGTM! But at the time I agreed with the issue I didn't have the information that the HA (High Availability) might be coming out soon. So I'm wondering if it's worth modifying the chart now.
I'll let @brunoocasali decide about it
Let's merge it @alallema since we don't have a clear path of how our Meili version of the HA will look yet. bors merge |
Build succeeded:
|
Pull Request
Related issue
Fixes #188
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: