Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Jest by Vitest #1369

Closed
wants to merge 18 commits into from
Closed

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 20, 2025

Pull Request

  • switch Jest tester to Vitest
  • remove tear-down logic, it's not required either way
  • do not test with jsdom anymore, because playground tests are already enough for browser environments, and we're not using anything Node.js specific anyways
  • add package.json "exports" field, adjust exports
  • update TypeScript and config
  • for now do not add ESLint config for Vitest

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 5c174e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@meilisearch/autocomplete-client Minor
@meilisearch/instant-meilisearch Minor
eslint-config-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Strift Strift changed the title Switch tester to Vitest Replace Jest by Vitest Jan 20, 2025
@Strift Strift marked this pull request as draft January 20, 2025 16:12
@flevi29
Copy link
Collaborator Author

flevi29 commented Jan 21, 2025

#1373

@flevi29 flevi29 closed this Jan 21, 2025
@flevi29 flevi29 deleted the jest-to-vitest branch January 21, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant