Fix swapIndexes flaky tests

meilisearch · Dec 20, 2023 · 706302e · 706302e
1 parent 16b854d
commit 706302e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/test/models/test_client.dart b/test/models/test_client.dart
@@ -108,14 +108,10 @@ class TestMeiliSearchClient extends MeiliSearchClient {
   }
 
   Future<void> disposeUsedResources() async {
-    final indexesCopy = usedIndexes.toList();
     await Future.wait([
       _deleteUsedIndexes(),
       _deleteUsedKeys(),
     ]);
-    if (indexesCopy.isNotEmpty) {
-      await _deleteTasksForDeletedIndexes(indexesCopy);
-    }
   }
 
   Future<void> _deleteUsedIndexes() async {
@@ -131,8 +127,4 @@ class TestMeiliSearchClient extends MeiliSearchClient {
           ),
     );
   }
-
-  Future<void> _deleteTasksForDeletedIndexes(List<String> indexes) async {
-    await deleteTasks(params: DeleteTasksQuery(indexUids: indexes));
-  }
 }
diff --git a/test/swaps_test.dart b/test/swaps_test.dart
@@ -9,21 +9,28 @@ void main() {
     setUpClient();
 
     test('swaps indexes from input', () async {
-      var books = ['books', 'books_new'];
-      var movies = ['movies', 'movies_new'];
+      var books = [randomUid('books'), randomUid('books_new')];
+      var movies = [randomUid('movies'), randomUid('movies_new')];
       var swaps = [SwapIndex(books), SwapIndex(movies)];
 
+      // first create the indexes to be swapped
+      for (var index in books + movies) {
+        await client.createIndex(index).waitFor(client: client);
+      }
+
       var response = await client
           .swapIndexes(
             swaps,
             deleteWhenDone: false,
           )
           .waitFor(
             client: client,
-            throwFailed: false,
+            throwFailed: true,
           );
 
       expect(response.type, 'indexSwap');
+      expect(response.error, null);
+      expect(response.status, 'succeeded');
       expect(response.details!['swaps'], [
         {'indexes': books},
         {'indexes': movies}