Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(vector): update Ollama endpoint #3016

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Guikingone
Copy link

Hi 👋🏻

As stated in the official Ollama documentation, the endpoint is /api/embed and not /api/embeddings.

Doc: https://github.com/ollama/ollama/blob/main/docs/api.md#generate-embeddings

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

Update on the embeddings endpoints for Ollama

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Hi 👋🏻 

As stated in the official Ollama documentation, the endpoint is `/api/embed` and not `/api/embeddings`.

Doc: https://github.com/ollama/ollama/blob/main/docs/api.md#generate-embeddings
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Guikingone, it's much appreciated.

Looks good to me as it does match their documentation, but I'm requesting a review from one of our devs just to be sure and in case this is interesting for them to know.

@guimachiavelli
Copy link
Member

Seems like this was also reported on the engine repo and is actually a possible breaking change of Ollama's API.

I'll delay merging until the devs have had a chance to do some research and decide the best course of action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants