Skip to content

Commit

Permalink
Merge #235
Browse files Browse the repository at this point in the history
235: Chromium-driver binary is added to Dockerfile  r=alallema a=mdraevich

## What does this PR do?
Fixes #185 (**1 task**)

Dockerfile was updated as follows:
1. **Chromium-driver** was installed using [debian repo](https://packages.debian.org/buster/chromium-driver).
2. The speed of build process was optimized by leveraging build cache ([more](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#leverage-build-cache)). 

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Hope you're doing great,
Matthew

Co-authored-by: Matthew <[email protected]>
Co-authored-by: Amélie <[email protected]>
  • Loading branch information
3 people authored Aug 2, 2022
2 parents e9f6c33 + 38d927a commit 5863acb
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
FROM python:3.8.4-buster

WORKDIR /docs-scraper

COPY . .

ENV LC_ALL C.UTF-8
ENV LANG C.UTF-8

WORKDIR /docs-scraper

RUN apt-get update -y \
&& apt-get install -y python3-pip libnss3
&& apt-get install -y python3-pip libnss3 \
&& apt-get install -y chromium-driver

RUN pip3 install pipenv


COPY Pipfile Pipfile
COPY Pipfile.lock Pipfile.lock

RUN pipenv --python 3.8 install


COPY . .

0 comments on commit 5863acb

Please sign in to comment.