Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Turkish normalizer #305

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Add Turkish normalizer #305

merged 3 commits into from
Aug 27, 2024

Conversation

tkhshtsh0917
Copy link
Contributor

Pull Request

Related issue

Fixes #294

What does this PR do?

  • Add Turkish normalizer definition & tests.
  • Update README.md.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

ManyTheFish
ManyTheFish approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

thank you @tkhshtsh0917,

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Aug 27, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit dd260b9 into meilisearch:main Aug 27, 2024
4 checks passed
@ManyTheFish ManyTheFish mentioned this pull request Aug 27, 2024
Closed
@tkhshtsh0917 tkhshtsh0917 deleted the add-turkish-normalizer branch August 27, 2024 11:37
@niyazialpay
Copy link

sorry this is not working, same problem still persist

@curquiza
Copy link
Member

@niyazialpay can you open an issue with the details of your context (version, what you did, what you get, what you expect)?

@niyazialpay niyazialpay mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalization Issue for Turkish Characters in Charabia
4 participants
@tkhshtsh0917 @niyazialpay @curquiza @ManyTheFish