Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pinyin-normalization optional #282

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Make the pinyin-normalization optional #282

merged 1 commit into from
Apr 17, 2024

Conversation

ManyTheFish
Copy link
Member

  • split the Chinese feature flag in order to deactivate a part of the pipeline
  • remove pinyin normalization from the default pipeline

Kerollmops
Kerollmops approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand everything, but I agree with you!
bors merge

charabia/Cargo.toml
Comment on lines +43 to +46
chinese = ["chinese-segmentation", "chinese-normalization"]
chinese-segmentation = ["dep:jieba-rs"]
chinese-normalization = []
chinese-normalization-pinyin = ["dep:pinyin", "chinese-normalization"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you reflect that on Meilisearch, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I don't think so,
everybody complains about this normalizer but I keep it in case another user of charabia wants to keep it

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Apr 17, 2024

Build succeeded:

  • tests

@ManyTheFish ManyTheFish merged commit 4e1f15b into main Apr 17, 2024
4 checks passed
@ManyTheFish ManyTheFish deleted the deactivate-pinyin-normalization branch April 17, 2024 15:23
@agourlay agourlay mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ManyTheFish @Kerollmops