Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lindera to 0.30.0 #279

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update Lindera to 0.30.0 #279

merged 1 commit into from
Apr 16, 2024

Conversation

mosuka
Copy link
Contributor

@mosuka mosuka commented Apr 13, 2024

Pull Request

Related issue

#265

What does this PR do?

  • Update Lindera version to 0.30.0. This downloads the dictionary from a GitHub repository, which seems to be more stable.
  • Optimize built dict.words file size. For unidic, dict.words size is decreased from 200.1MB to 106.3MB.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

ManyTheFish
ManyTheFish approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mosuka,
thank you for your contribution,
Have a good day!
bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Apr 16, 2024

Build succeeded:

  • tests

@meili-bors meili-bors bot merged commit a44a213 into meilisearch:main Apr 16, 2024
4 checks passed
@mosuka mosuka deleted the lindera branch April 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosuka @ManyTheFish