Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support markdown formatted codeblocks #275

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

6543
Copy link
Contributor

@6543 6543 commented Mar 12, 2024

Pull Request

Related issue

Fixes go-gitea/gitea#29740 (comment)

What does this PR do?

add ` as seperator to support markdown formated text

PR checklist

Please check if your PR fulfills the following requirements:

Does this PR fix an existing issue, or have you listed the changes applied in the PR description...

well I can file a issue if desired but I think this is a minor change?

  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes
    -> I hope so ;)

@ManyTheFish
Copy link
Member

Hello @6543,
Is this PR ready for review?
If yes, can you put it as ready for review and assign me to the review?

Thank you!

@6543 6543 marked this pull request as ready for review March 13, 2024 12:57
@6543
Copy link
Contributor Author

6543 commented Mar 13, 2024

@ManyTheFish Done

Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Thank you for your PR! 🎉

bors merge

Copy link
Contributor

meili-bors bot commented Mar 14, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 8bd1936 into meilisearch:main Mar 14, 2024
4 checks passed
@6543 6543 deleted the support_markdown-codeblocks branch March 14, 2024 12:14
meili-bors bot added a commit to meilisearch/meilisearch that referenced this pull request Mar 25, 2024
4511: Bump charabia to 0.8.8 r=ManyTheFish a=6543

... and update lock file

this will add the fix (meilisearch/charabia#275) to support markdown formatted codeblocks

Co-authored-by: 6543 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants