Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused FstSegmenter warning when not using khmer compiler features #261

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

timvisee
Copy link
Contributor

Pull Request

Related issue

Fixes #260
Depends on #259

What does this PR do?

  • Fixes compilation warnings without thai or khmer features
  • Puts related module behind conditional feature attribute

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

I didn't know qdrant was using charabia; that's awesome! I love your work

May I ask in which part of your pipeline it found its place? 👀

@irevoire
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Jan 30, 2024

Build succeeded:

  • tests

@meili-bors meili-bors bot merged commit ec889b6 into meilisearch:main Jan 30, 2024
4 checks passed
@timvisee
Copy link
Contributor Author

timvisee commented Jan 31, 2024

I didn't know qdrant was using charabia; that's awesome! I love your work

😄

May I ask in which part of your pipeline it found its place? 👀

Of course. We use it to tokenize our full text payload/metadata indexes. Saves us a lot of hassle building our own tokenizer. Thank you for your work!

In code: https://github.com/qdrant/qdrant/blob/dev/lib/segment/src/index/field_index/full_text_index/tokenizers.rs

Again, thanks for handling this PR quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation warnings when not using default features
2 participants