feat: allow for vrouter partner config in update vxc call #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mega-alex
reviewed
Sep 24, 2024
vxc.go
Outdated
| case *VXCOrderVrouterPartnerConfig: | ||
| update.BEndPartnerConfig = partnerConfig | ||
| default: | ||
| return nil, errors.New("a end partner config type not supported for VXC update") |
There was a problem hiding this comment.
I would mention here, and on the B end, that the only supported end config is VRouter.
MegaportPhilipBrowne
force-pushed
the
feat/vxc-partnerConfig-updates
branch
from
f5f7200
to
9054191
Compare
mega-alex
previously approved these changes
Oct 1, 2024
…ter for bend in vxc updates
MegaportPhilipBrowne
force-pushed
the
feat/vxc-partnerConfig-updates
branch
from
420689a
to
508032b
Compare
mega-alex
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions
Please read the (Contribution Guidelines)[https://github.com/megaport/megaportgo/wiki/Contributing.md]
prior to lodging Pull Requests (PR).
Description
Please include a summary of the change and which issue is fixed. Please also include any relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Contributor Agreement
Lodging this Pull Request (PR) indicates agreement with the project's
(Contributor License Agreement)[https://github.com/megaport/megaportgo/wiki/Megaport_Contributor_Licence_Agreement.md].
Please read the Contributor Licence Agreement (CLA) and affirm your acceptance here:
[I have read an accept the CLA]
NOTE If multiple authors have commited to this PR, each one will need to comment on this PR and
agree to the CLA before this PR can be accepted.