fix(admin): loadConfig does not allow serve to be truly configurable
#11238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `serve` is always `true` allowing to always start the Admin UI with the new logic in the `develop.js` command file in @medusajs/medusa - `loadConfig` in the @medusajs/admin is no longer overriding the `serve` function to false, allowing to fix the current bug we have in 1.20.11 where the Admin UI cannot be launched at all
🦋 Changeset detectedLatest commit: d42c10e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
adevinwild
commented
Jan 31, 2025
| @@ -35,7 +35,6 @@ export const loadConfig = (isDev?: boolean): PluginOptions | null => { | |||
| if (isDev) { | |||
| config = { | |||
| ...config, | |||
| serve: false, | |||
There was a problem hiding this comment.
We remove the forced false value here to make sure it's configurable as explained in the docs
adevinwild
commented
Jan 31, 2025
| @@ -45,7 +44,7 @@ export const loadConfig = (isDev?: boolean): PluginOptions | null => { | |||
| const options = (plugin as { options: PluginOptions }).options ?? {} | |||
|
|
|||
| config = { | |||
| serve: isDev ? false : options.serve ?? config.serve, | |||
| serve: options.serve ?? config.serve, | |||
There was a problem hiding this comment.
Same goes here, to make sure it's fully configurable
kasperkristensen
approved these changes
Feb 4, 2025
olivermrbl
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11237
Solution that PR introduce
serveis alwaystrueallowing to always start the Admin UI with the new logic in thedevelop.jscommand file in@medusajs/medusaloadConfigin the@medusajs/adminis no longer overriding theservefunction to false, allowing to fix the current bug we have in v1.20.11 where the Admin UI cannot be launched at allQuick preview of the new behavior on a project
In this preview, I try with the different values and how it behaves with the fix.
serveoption -> Default totrue; Trigger the admin developserveset tofalse-> Ignore the admin develop commandserveset totrue-> Trigger the admin developloadConfig.mp4