-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit and integration test for stock out #64
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestoteo
requested review from
inromualdo and
paulpascal
and removed request for
paulpascal
October 16, 2024 22:38
inromualdo
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @ernestoteo . I left some comments
Should we focus on writing unit test of the function? It seems like you write integration tests here... |
I have fix the changes and added unit test for stock out. |
ernestoteo
changed the title
Add unit test for stock out
Add unit and integration test for stock out
Oct 28, 2024
ernestoteo
requested review from
paulpascal and
inromualdo
and removed request for
inromualdo
October 28, 2024 09:16
ernestoteo
force-pushed
the
53_stock_out_unit_test
branch
from
November 5, 2024 15:01
6b6c4f5
to
b34b070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53