Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and integration test for stock out #64

Closed
wants to merge 7 commits into from

Conversation

ernestoteo
Copy link
Contributor

#53

@ernestoteo ernestoteo requested review from inromualdo and paulpascal and removed request for paulpascal October 16, 2024 22:38
Copy link
Collaborator

@inromualdo inromualdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @ernestoteo . I left some comments

test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
test/stock-out.spec.js Outdated Show resolved Hide resolved
@inromualdo
Copy link
Collaborator

Should we focus on writing unit test of the function? It seems like you write integration tests here...

@ernestoteo
Copy link
Contributor Author

@inromualdo ,

I have fix the changes and added unit test for stock out.

@ernestoteo ernestoteo changed the title Add unit test for stock out Add unit and integration test for stock out Oct 28, 2024
@ernestoteo ernestoteo requested review from paulpascal and inromualdo and removed request for inromualdo October 28, 2024 09:16
@ernestoteo ernestoteo closed this Nov 6, 2024
@ernestoteo ernestoteo deleted the 53_stock_out_unit_test branch November 6, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants