Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub-section for review comment labeling in code review section #1732

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

sugat009
Copy link
Member

Description

Add a sub-section for labeling review comments in a PR in the code review section.
Doc Page

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to leave this unattended too!

nice work here - this is great to capture!

Recommend we host a small copy of the list of labels from the source site. We (or the site!) might deviate over time so this is a good list to keep on our docs I Think.

content/en/contribute/code/workflow.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sugat009 sugat009 merged commit 22723a6 into main Dec 20, 2024
2 checks passed
@sugat009 sugat009 deleted the conventional_comments branch December 20, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants