Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate contact summary #1688

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Migrate contact summary #1688

merged 5 commits into from
Nov 6, 2024

Conversation

esthermmoturi
Copy link
Contributor

@esthermmoturi esthermmoturi commented Nov 6, 2024 •
edited
Loading

Closes #1679

andrablaj
andrablaj requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _index.md weights need review to ensure there are no overlapping weights and the sections appear in a logical order.

content/en/building/contact-summary/_index.md Outdated Show resolved Hide resolved
content/en/building/contact-summary/contact-summary-overview.md Outdated Show resolved Hide resolved
content/en/building/contact-summary/contact-summary-overview.md Outdated Show resolved Hide resolved
content/en/building/contact-summary/contact-summary-templated.md Outdated Show resolved Hide resolved
@esthermmoturi
Copy link
Contributor Author

@andrablaj I'll review the weighting of all pages

andrablaj
andrablaj approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@andrablaj andrablaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪐

@esthermmoturi esthermmoturi merged commit 56e552f into main Nov 6, 2024
2 checks passed
@esthermmoturi esthermmoturi deleted the migrate-contact-summary-section branch November 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrablaj andrablaj andrablaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move contact-summary section
2 participants
@esthermmoturi @andrablaj