-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(#1658): add openmrs and ltfu docs #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! I have added some minor comments and typo fixes but approving now to unblock.
content/en/building/guides/interoperability/ltfu_reference_workflow.md
Outdated
Show resolved
Hide resolved
content/en/building/guides/interoperability/ltfu_reference_workflow.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @witash. Left some suggestions inline. Let me know what you think.
Co-authored-by: njuguna-n <[email protected]>
@witash I merged the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the extended work in putting together this doc!
I shared a first batch of suggestions. Mainly:
- Replace
_
with-
in the file/folder names. - Simplify
linkTitle
names to make the hierarchy simpler to read and navigate. - Added
weight
to pages so that the guides appear in a logical order.
I will go through the OpenMRS steps and add more comments, if any.
content/en/building/guides/interoperability/ltfu_reference_workflow.md
Outdated
Show resolved
Hide resolved
content/en/building/guides/interoperability/ltfu_reference_workflow.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions based on my own comments above.
Co-authored-by: Andra Blaj <[email protected]>
I removed the section on incoming patients from OpenMRS. Although technically the Gandaki flow does support this, it requires a lot of steps that may be difficult to generalize, so maybe we can not support this "officially" or include any documentation on it, which will necessarily either be incomplete, or add a lot stuff to this document. |
@witash I see various updates on this PR. Is it ready for another review? |
I think this is ready for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@witash I reviewed the content but didn't try to reproduce the OpenMRS steps.
This is a massive amount of work, thank you for putting it together! ⚡️
I added a few non-blocking suggestions.
It would be lovely if someone could go through the OpenMRS setup steps (@lorerod, @mrjones-plip ?) to validate the clarity of the instructions. I will try to do this myself next week, but I don't want to be a blocker to having this merged.
@andrablaj, I have a pending re-review of this PR, and I will follow the OpenMRS setup steps next week. |
Co-authored-by: Andra Blaj <[email protected]>
Co-authored-by: Andra Blaj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the effort you've put into this documentation. I’m reviewing it by reproducing the steps on my local machine using the cht-interoperability openmrs-mediator branch.
### Sending forms OpenMRS->CHT | ||
|
||
When sending form data to CHT, first find, create, or import the concepts in OpenMRS, and create the forms in OpenMRS. | ||
Then create a form in CHT to receive the reports [as described in the CHT interop config documentation]({{< ref "building/guides/interoperability/cht-config#outbound-reports" >}}); the codes from OpenMRS are the field names, and labels can be added for human readability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is pre-configured in the cht-interoperability repository, please include a notice here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR to unblock as the documentation aligns with what is expected, and we will address the pending issues in separate, independent tickets.
"gender": "male", | ||
"birthDate": "1980-06-06" | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is expected, you can add a step to explain what this is.
Description
Closes #1658
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.