Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#7462): add doc for new cht-form npm scripts #1232

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

jkuester
Copy link
Contributor

@jkuester jkuester commented Nov 8, 2023

medic/cht-core#7462
medic/cht-core#8153

See this thread for more context regarding the style guide changes around implicit returns.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Copy link
Member

@m5r m5r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is a detail in my comment I'd like to clear up before merging but I'll approve to not block it while I'm offline

content/en/contribute/code/style-guide.md Outdated Show resolved Hide resolved
jkuester and others added 2 commits November 28, 2023 15:35
Co-authored-by: Mokhtar <[email protected]>
# Conflicts:
#	content/en/contribute/code/core/build-commands.md
@jkuester jkuester merged commit 965c592 into main Nov 28, 2023
2 checks passed
@jkuester jkuester deleted the 7462_forms_module branch November 28, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants