fix(cht-conf-test-harness#239): update contact saver to fix error

[kennsippell]

Description

Note the base branch for this change is enketo-service-refactor. This contains a fix for medic/cht-conf-test-harness#239 but should not be merged to main. I did not open a cht-core issue for this.

In production, we have the typescript line repeated?.child_data || [];

In the enketo-service-refactor branch used by cht-conf-test-harness, we have this near enemy repeated ? repeated.child_data : [];

The behavior differs for defined values of repeated with an undefined value of child_data. This change reconciles the difference.

Code review checklist

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or e2e where appropriate
• Internationalised: All user facing text
• Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

• CHT_CORE_COMPOSE_URL
• COUCH_SINGLE_COMPOSE_URL
• COUCH_CLUSTER_COMPOSE_URL

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[jkuester]

👍

[jkuester]

Thanks for the clear explanation!

[kennsippell]

@jkuester I'm unsure if tests are still working on this branch. I can keep retrying them, but I'd love your opinion on how best to proceed. Merge master? Keep retrying? Ignore failures? etc

[jkuester]

Oh, yeah, I would not bother with the tests on this branch anymore! (Particularly for a low-risk change like this.) I will merge this now.

The good news is that we are getting very close to a go forward solution that does not include this branch!!!! 🎉

[kennsippell]

Thanks and good luck, sir!