feat(#263) - Support for CHT Core 4.11 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennsippell
commented
Jul 29, 2024
kennsippell
commented
Jul 29, 2024
kennsippell
commented
Aug 1, 2024
kennsippell
changed the title
jkuester
requested changes
Oct 23, 2024
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "docs": "npx jsdoc src/*.js src/**/*.js ./JSDOC.md -d docs", | |||
| "explore": "node ./project-explorer/build-assets.js --path=./test/collateral/project-without-source --formPath=./test/collateral && cd project-explorer && webpack && google-chrome ./project-explorer.html", | |||
| "eslint": "npx eslint .", | |||
| "build-ci": "npm run docs && npm run eslint && ./build.sh --force && npm test", | |||
| "build-ci": "npm run docs && npm run eslint && npm test", | |||
There was a problem hiding this comment.
Suggested change
| "build-ci": "npm run docs && npm run eslint && npm test", | |
| "build-ci": "npm run docs && npm run eslint && ./build.sh --force && npm test", |
We should still be able to run the build script on CI right? At this point, even with --force, only 4.11.0 will be built since that is the only thing contained in cht_versions. If at all possible, I think it would be good to still run this just to make sure it works...
There was a problem hiding this comment.
I think it is important that the tests run against the files which are being committed into the dist folder. That is what will be distributed to end users.
I agree it is also important to test that the build script isn't broken. So I therefore will run build in a separate github action. Seem ok?
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263
CHT Core 4.11.0 adds support for a new
cht.v1.analyticsobject when viewing the contact summary of the user's facility. This change adds support for 4.11.0 and wires up this new object.