-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEB/RPM/mac] master branch - debug all unix packages, switch to DEB/RPM #1112
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Privet plugins must be stay
I created a wiki medInria page with the DEB/RPM documentation : https://github.com/medInria/medInria-public/wiki/DEB-RPM-management |
👍 |
938f3d7
to
3c6258f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job for deb and rpm compatibility just few modifications are needed.
# | ||
# For more details see : http://www.cmake.org/cmake/help/v2.8.9/cmake.html#module:CPack | ||
|
||
if (CPACK_GENERATOR STREQUAL "ZIP") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it
@@ -1,2 +1,2 @@ | |||
execute_process(COMMAND rm -f @PROJECT_BINARY_DIR@/medInria-@@PROJECT_NAME@[email protected]) | |||
execute_process(COMMAND @PROJECT_BINARY_DIR@/packaging/apple/mac_packager.sh @medInria_BINARY_DIR@/bin/plugins @medInria_BINARY_DIR@/bin/plugins_legacy @PRIVATE_PLUGINS_DIRS@ @PRIVATE_PLUGINS_LEGACY_DIRS@) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep private
file(REMOVE_RECURSE ${DIR}/lib/cmake) | ||
file(REMOVE_RECURSE ${DIR}/lib64/cmake) | ||
file(REMOVE_RECURSE ${DIR}/lib/vtk-8.0/CMake) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify vtk cleaning phase with new version of vtk.
I was working on the packaging system, and i began to test & debug the old DEB and RPM system that was already in medInria from a long time ago. Finally i managed to get a smooth working DEB and RPM system, and debug the macOS packaging bug on master.
No more launcher script for the user, a real linux package that can be called from the terminal or the application list, put in dock favorites, installed and removed!
Also, cleaning the packages reduced the size. For instance for Ubuntu 262Mo to 243 Mo.
Fixes
Test branches
Ubuntu DEB Documentation
Devs : regular
make package
compilation.Fedora RPM Documentation
Prerequisites on Fedora to create a RPM package:
sudo yum install redhat-lsb-core rpm-build
Devs : regular
make package
compilation.