Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add syncHostStyles API to disable iframe style sync #593

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisvxd
Copy link
Member

@chrisvxd chrisvxd commented Sep 1, 2024

Follow-on for #409

CC @nicolas-angelo

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 4:16pm
puck-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 4:16pm

Sync the host styles to the iframe. Defaults to `true`.

If this isn't working, you may need to inject styles manually using the iframe [override API](/docs/api-reference/overrides/iframe), or make use of a [plugin](/docs/extending-puck/plugins).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API won't work until we can isolate the Puck styles from the required styles. Setting syncHostStyles to false will prevent any Preview styles from loading, making the preview unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant