Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding permissions to core actions and disabling on Hero #574

Merged
merged 11 commits into from
Aug 28, 2024
Merged

feat: adding permissions to core actions and disabling on Hero #574

merged 11 commits into from
Aug 28, 2024

Conversation

xaviemirmon
Copy link
Contributor

@xaviemirmon xaviemirmon commented Aug 21, 2024 •
edited
Loading

Linked to #461

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:42am
puck-docs ✅ Ready (Inspect) Visit Preview Aug 28, 2024 8:42am

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024

@xaviemirmon is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

@xaviemirmon xaviemirmon marked this pull request as ready for review August 21, 2024 12:34
@chrisvxd chrisvxd mentioned this pull request Aug 22, 2024
Closed
10 tasks
chrisvxd
chrisvxd requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome progress! Another round of feedback for ya

packages/core/lib/use-puck.ts Outdated Show resolved Hide resolved
packages/core/lib/use-puck.ts Outdated Show resolved Hide resolved
packages/core/components/Drawer/index.tsx Outdated Show resolved Hide resolved
apps/demo/app/custom-ui/[...puckPath]/client.tsx Show resolved Hide resolved
packages/core/components/Drawer/styles.module.css Show resolved Hide resolved
@xaviemirmon
fix: renaming API variable to "item," adding disabled state for drawe…
c84b3c6 
…r items and tweaking cursor icon if disabled
@chrisvxd chrisvxd mentioned this pull request Aug 27, 2024
Closed
chrisvxd
chrisvxd requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! One weird bug in the comments.

apps/demo/app/custom-ui/[...puckPath]/client.tsx Outdated Show resolved Hide resolved
apps/demo/app/custom-ui/[...puckPath]/client.tsx Show resolved Hide resolved
packages/core/lib/use-puck.ts Outdated Show resolved Hide resolved
@chrisvxd chrisvxd mentioned this pull request Aug 28, 2024
Closed
chrisvxd
chrisvxd approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chrisvxd chrisvxd merged commit cad95b8 into measuredco:main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvxd chrisvxd chrisvxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xaviemirmon @chrisvxd