remove setuptools from runtime dependencies #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyfaidx does not rely on setuptools during day to day operation, so it can be safely removed from the runtime dependencies. For the rationale, this change originates from the deprecation of the Debian package python3-pkg-resources along the upcoming Python 3.13 reported in [Debian bug #1083691]. For short, python3-pkg-resources happens to be pulled by the packaging tools when runtime dependency on setuptools is declared. [Debian bug #1083691]: https://bugs.debian.org/1083691 Signed-off-by: Étienne Mollier <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 1073 1073
======================================
Misses 1073 1073 ☔ View full report in Codecov by Sentry. |
|
Good catch, and I'm glad to remove an unused dependency - especially to make downstream packaging easier. |
|
I've merged the change and created a new release (https://github.com/mdshw5/pyfaidx/releases/tag/v0.8.1.3) that should be on PyPI in a few minutes. |
|
Thank you, I wait for the current packaging iteration of pyfaidx in Debian sid to migrate to testing (in a two days, barring unforeseen issues), but I confirm your newer version is caught by our newer versions scanner.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyfaidx does not rely on setuptools during day to day operation, so it can be safely removed from the runtime dependencies.
For the rationale, this change originates from the deprecation of the Debian package python3-pkg-resources along the upcoming Python 3.13 reported in Debian bug #1083691. For short, python3-pkg-resources happens to be pulled by the packaging tools when runtime dependency on setuptools is declared.