Disambiguate super from this inheritance
#2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the child class inherits a function, calling it from `super` behaves identically to calling it from `this`. But by overriding the inherited definition, the example demonstrates that `super` bypasses the child’s definition and goes to the parent’s instead.
davidmcguiredesign
requested review from
Josh-Cena
and removed request for
a team
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
Josh-Cena
reviewed
Oct 18, 2024
Co-authored-by: Joshua Chen <[email protected]>
Josh-Cena
approved these changes
Oct 18, 2024
|
Thanks Josh! Sorry about the early “resolution”—I’m still new to open-source contribution mechanisms and etiquette. |
|
You accepted my suggestion and automatically marked the conversation as resolved—that's exactly how it should go :) |
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the child class inherits a function, calling it from
superbehaves identically to calling it fromthis. But by overriding the inherited definition, the example can now demonstrate thatsuperbypasses the child’s definition.Motivation
Understanding
superis easier when contrasted withthisthan when defined in (comparative) isolation.