Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link in audio.html #2702

Merged
merged 1 commit into from
Jan 6, 2024
Merged

fix link in audio.html #2702

merged 1 commit into from
Jan 6, 2024

Conversation

Yuriy113
Copy link
Contributor

@Yuriy113 Yuriy113 commented Jan 4, 2024

Description

Moved the download link outside the <audio> element.

Motivation

The <a> tag was functioning incorrectly within the <audio> element. After the changes, the link works correctly

Additional details

Related issues and pull requests

No additional details are required for this modification.

Before:
image
After:
image

@Yuriy113 Yuriy113 requested a review from a team as a code owner January 4, 2024 13:27
@Yuriy113 Yuriy113 requested review from dipikabh and removed request for a team January 4, 2024 13:27
Copy link

github-actions bot commented Jan 4, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍. Thanks for submitting this fix, @Yuriy113

@dipikabh dipikabh merged commit 7c55e54 into mdn:main Jan 6, 2024
5 checks passed
Copy link

github-actions bot commented Jan 6, 2024

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@dipikabh
Copy link
Contributor

dipikabh commented Jan 6, 2024

Welcome to the MDN Web Docs project! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants