Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ::after instead of :after #2698

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Use ::after instead of :after #2698

merged 1 commit into from
Dec 24, 2023

Conversation

ator-dev
Copy link
Contributor

Description

Use correct pseudo-element syntax rather than the older variant

Motivation

Less confusing to people who may not know the history of pseudo-elements; shows distinction from pseudo-classes

Additional details

Related issues and pull requests

Use correct pseudo-element syntax rather than the older variant
@ator-dev ator-dev requested a review from a team as a code owner December 24, 2023 12:38
@ator-dev ator-dev requested review from estelle and removed request for a team December 24, 2023 12:38
Copy link

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 76fb288 into mdn:main Dec 24, 2023
5 checks passed
@teoli2003
Copy link
Contributor

Thanks a lot!

This PR looks good to me.

Congratulations upon your first merged commit here! Welcome aboard! ✌️

Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@ator-dev
Copy link
Contributor Author

ator-dev commented Dec 24, 2023

@teoli2003 Thanks, no worries! It's only a small change, but now I feel ready to start contributing. I love MDN and have used it as my primary web development resource for years (:

@ator-dev ator-dev deleted the patch-1 branch December 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants