-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add return_call example for WASM #2693
Conversation
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
@eqrion could you please have a look? |
Co-authored-by: Yury Delendik <[email protected]>
@yurydelendik thank you! However, the code still won’t run if pasted into the playground we have on the call page, for example:
Do you have an idea if it’s the problem with the playground? |
I have a little insight into how playground works. The WebAssembly engine does not know about WAT and text representation. The transformation to bytecode is happening somewhere else. That something perhaps needs to be updated with new wasm specifications support. |
If not mistaken, There is a reference to |
Thank you for investigating! I’ll reach out to platform engineers about this. |
once #2845 landed we can get this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved. (I don't have "Approve" permission)
Description
Adds example for
return_call
, tail call version of thecall
. I took it from the explainer.But there’s a catch: the playground shows an error when I try to run the code. There might be two reasons for that:
return_call
, see the error belowMotivation
To support enabled tail calls in Firefox 121.
Additional details
Related issues and pull requests