fix: array-reduce requiring horizontal scrolling
#2633
Conversation
Without this change
|
With this change (presumably)
|
| // so we can extend this repository's default `prettier` configuration. | ||
| module.exports = { | ||
| ...require('../../../.prettierrc.json'), | ||
| printWidth: 100, |
There was a problem hiding this comment.
| printWidth: 100, | |
| // This prevented at least one example from requiring horizontal scrolling. | |
| printWidth: 100, |
There was a problem hiding this comment.
It might be worth documenting why we're overriding the base prettier config.
There was a problem hiding this comment.
So it appears I set the print width to 120 which might not even be desirable overall. It looks like the original objection to 80 as a print width was for changes in an .md file (which we can maybe handle with overrides?), not a code example. It might be worth considering getting rid of the printWidth key altogether and using the default which is what we use in content with overrides for html/md. We should check how many files this changes though
edit: It might be good to change the base config only. This is a neat approach, adding an overriding config in a subdir, but it might get confusing with separate config files dotted through the source like this.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks @hamirmahal - should be fixed now in #2648 🙌🏻 |
|
You're welcome, @bsmth! Thanks for the fix. |
hamirmahal
deleted the
fix/array-reduce-example-not-fitting-in-demo-section
branch
fixes #2632.