Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): Fix 2 contrast issues #2452

Merged
merged 5 commits into from
Feb 28, 2023
Merged

fix(css): Fix 2 contrast issues #2452

merged 5 commits into from
Feb 28, 2023

Conversation

rohini-ranjanR
Copy link
Contributor

@rohini-ranjanR rohini-ranjanR commented Feb 24, 2023 •
edited
Loading

Description

This PR improves the contrast of the following examples:

Motivation

Additional details

Related issues and pull requests

Relates #2054

NiedziolkaMichal
NiedziolkaMichal requested changes Feb 26, 2023
View reviewed changes
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
Text parent has too low contrast of 1,71 which should be fixed. Except for that, everything looks fine.

Oh, you also need to fix ESLint issues. Simply run the script fix:css before your next commit.

@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 26, 2023
Open
@rohini-ranjanR
fix(css): change and add color to transform style
ac5a873 
change color and add a color attribute for transform style
@rohini-ranjanR rohini-ranjanR changed the title improve contrast of transform-style fix (css): Fix 2 contrast issues Feb 27, 2023
@rohini-ranjanR rohini-ranjanR changed the title fix (css): Fix 2 contrast issues fix(css): Fix 2 contrast issues Feb 27, 2023
NiedziolkaMichal
NiedziolkaMichal approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thank you for your contribution

@NiedziolkaMichal NiedziolkaMichal merged commit 7f7dc1d into mdn:main Feb 28, 2023
@mdn-bot mdn-bot mentioned this pull request Feb 28, 2023
Merged
@rohini-ranjanR rohini-ranjanR deleted the contrast_transform_style branch February 28, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiedziolkaMichal NiedziolkaMichal NiedziolkaMichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohini-ranjanR @NiedziolkaMichal