Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): FIx group for CSS Box Sizing #914

Merged
merged 4 commits into from
Jan 28, 2025
Merged

chore(css): FIx group for CSS Box Sizing #914

merged 4 commits into from
Jan 28, 2025

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 marked this pull request as ready for review January 28, 2025 07:34
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner January 28, 2025 07:34
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team January 28, 2025 07:34
bsmth
bsmth reviewed Jan 28, 2025
View reviewed changes
css/functions.json Outdated Show resolved Hide resolved
@bsmth
Copy link
Member

bsmth commented Jan 28, 2025

Everything looks good, one comment about fit-content()

skyclouds2001
skyclouds2001 commented Jan 28, 2025
View reviewed changes
css/functions.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 requested a review from bsmth January 28, 2025 13:29
@skyclouds2001 skyclouds2001 mentioned this pull request Jan 28, 2025
Merged
bsmth
bsmth approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bsmth bsmth merged commit 9c304df into mdn:main Jan 28, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Open
@skyclouds2001 skyclouds2001 deleted the CSS-Box-Sizing branch January 28, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @bsmth