Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove see also #37785

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove see also #37785

wants to merge 4 commits into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 24, 2025

Page type doesn't have see also section. Added one link into the text, and deleted the two others.

@estelle estelle requested a review from a team as a code owner January 24, 2025 09:54
@estelle estelle requested review from chrisdavidmills and removed request for a team January 24, 2025 09:54
@github-actions github-actions bot added the size/s [PR only] 6-50 LoC changed label Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Preview URLs

(comment last updated: 2025-01-24 18:23:11)

- : An advanced level guide to arrays and their cousins, typed arrays.
- {{jsxref("Array")}}
- : The `Array` object reference page — for a detailed reference guide to the features discussed in this page, and many more.
- [Aside: Intro to arrays](https://v2.scrimba.com/the-frontend-developer-career-path-c0j/~06e?via=mdn), Scrimba <sup>_MDN Curriculum partner_</sup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills We might want to place this link somewhere else, instead of silently dropping it.

@@ -8,7 +8,7 @@ page-type: learn-module-chapter

{{PreviousMenuNext("Learn_web_development/Core/Scripting/Useful_string_methods", "Learn_web_development/Core/Scripting/Silly_story_generator", "Learn_web_development/Core/Scripting")}}

In this lesson we'll look at arrays — a neat way of storing a list of data items under a single variable name. Here we look at why this is useful, then explore how to create an array, retrieve, add, and remove items stored in an array, and more besides.
In this lesson we'll look at arrays — a neat way of storing a list of data items under a single variable name. Here we look at why this is useful, then explore how to create an {{jsxref("array")}}, retrieve, add, and remove items stored in an array, and more besides.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a regular Markdown link; otherwise it adds code formatting (I know you can suppress code formatting but I dislike the 3rd and 4th parameters of jsxref)

@estelle estelle requested a review from Josh-Cena January 24, 2025 18:21
@chrisdavidmills
Copy link
Contributor

Can I ask — where is this particular page structure type defined; where does it specify that it has no "See also" section?

Going forward, we want to have "See also" sections on learn web development pages.

I agree with removing the "Indexed collections" link, as that's not very helpful to beginners on the learning pathway.

I am not so sure about removing the Arrays reference link. We'll have to discuss what we want to do for reference links, but for beginner's tutorials, it is nice to point out what the page is for and what you will find there. But, we'd have to make sure consistent on the learn pages if we do decide to go with that.

And as for the Scrimba link — we want to keep that. I've already created a PR that adds guidelines for adding partner links safely without them getting out of control, etc.: #37792

@estelle
Copy link
Member Author

estelle commented Jan 27, 2025

Can I ask — where is this particular page structure type defined; where does it specify that it has no "See also" section?

No other pages in the section have a see also
We can discuss adding see also's to learn in an issue,
If we decide to add them, i'm ok with that i think, but this see also section was not helpful on this particular page

Going forward, we want to have "See also" sections on learn web development pages.

At this time, we do not have see also sections, so this can be removed.

And as for the Scrimba link — we want to keep that.

This linked video is not a good addition to this page, which is why I didn't add it into the content. I watched it in its entirety. If it needs to be kept for the partnership, maybe it fits somewhere in /curriculum? but not on this page.

@estelle
Copy link
Member Author

estelle commented Jan 27, 2025

We can discuss adding see also's to learn in an issue, If we decide to add them, i'm ok with that

Ooops. Some sections in learn do have see also sections, but not this path.

@chrisdavidmills
Copy link
Contributor

Ooops. Some sections in learn do have see also sections, but not this path.

Yup, and we want to have more added, in a way that makes sense. I deliberately added the Array link on this page in a way that I thought made sense for beginners. If it is a link at the top of the page somewhere, with no explanation, then it won't make sense to beginners. If we add it as further reading for those who want to find out about more array methods, with some explanation, then there is more change it will make sense.

This linked video is not a good addition to this page, which is why I didn't add it into the content.

I think the Scrimba link is useful. One reason we considered adding partner content to learn was to provide non-text equivalents to our walls of text. Learners these days want multiple learning styles, not just text.

Exactly how to present See also links like these in the new learn section needs some discussion, and I've added such instances as examples that can be discussed. It is harder to discuss them if you remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants