adapt "note box" due to a change in the interactive editor #20491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before a merged pr there was just one link with the target="_blank" attribute now both of them have it
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
before a merged pr there was just one link with the target="_blank" attribute now both of them have it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
before the merged pr in mdn/learning-area#495 there was just one link with the
target="_blank"attribute - now both of them have it (issue #20436)i rewrote the sentence in the note box in plural and because the second
<a>element is a mail anchor, i wrote "so that the links..." instead of "so that the page...".Motivation
To make the content correct.
Additional details
i am always open for suggestions and improvements :)
Related issues and pull requests
Relates to pr mdn/learning-area#495 and issue #20436