Make "Assessment or further help" sections consistent #16032

glmvc · 2022-05-14T19:21:46Z

Summary

Like discussed and suggested in pr #15579:

adapt the "Assessment or further help" sections (at the end of assessments and test your skill articles) to be more consistent across the HTML and CSS learning modules
the other modules will follow if i move on in the learning section and if wanted of course

Motivation

To make things more consistent...

Metadata

Adds a new document
Rewrites (or significantly expands) a document
Fixes a typo, bug, or other error

github-actions · 2022-05-14T19:24:24Z

Preview URLs

Flaws

Note! 21 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn/CSS/First_steps/Styling_a_biography_page
Title: Styling a biography page
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
Title: A cool-looking box
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
Title: Creating fancy letterheaded paper
on GitHub
Flaw count: 2

macros:
- /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/Building_blocks/Fundamental_CSS_comprehension
Title: Fundamental CSS comprehension
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/Styling_text/Typesetting_a_homepage
Title: Typesetting a community school homepage
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/CSS_layout/Fundamental_Layout_Comprehension
Title: Fundamental layout comprehension
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
Title: Structuring a page of content
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
Title: Marking up a letter
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/HTML/Tables/Structuring_planet_data
Title: Structuring planet data
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
Title: Mozilla splash page
on GitHub
Flaw count: 1

broken_links:
- Link points to the page it's already on

External URLs

URL: /en-US/docs/Learn/CSS/First_steps/Styling_a_biography_page
Title: Styling a biography page
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/Building_blocks/Selectors/Selectors_Tasks
Title: Test your skills: Selectors
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Box_Model_Tasks
Title: Test your skills: The box model
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Test_your_skills_backgrounds_and_borders
Title: Test your skills: Backgrounds and borders
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Writing_Modes_Tasks
Title: Test your skills: Writing modes and logical properties
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Images_tasks
Title: Test your skills: Images and form elements
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Values_tasks
Title: Test your skills: Values and units
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Tables_tasks
Title: Test your skills: Tables
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Cascade_tasks
Title: Test your skills: The Cascade
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
Title: A cool-looking box
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/Building_blocks/Sizing_tasks
Title: Test your skills: Sizing
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Overflow_Tasks
Title: Test your skills: Overflow
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
Title: Creating fancy letterheaded paper
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/Building_blocks/Fundamental_CSS_comprehension
Title: Fundamental CSS comprehension
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/Styling_text/Typesetting_a_homepage
Title: Typesetting a community school homepage
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/CSS_layout/rwd_skills
Title: Test your skills: Responsive web design and media queries
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Position_skills
Title: Test your skills: Positioning
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Fundamental_Layout_Comprehension
Title: Fundamental layout comprehension
on GitHub

https://discourse.mozilla.org/c/mdn/learn/250 (1 time) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Grid_skills
Title: Test your skills: Grid
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Floats_skills
Title: Test your skills: Floats
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Multicol_skills
Title: Test your skills: Multicol
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/CSS/CSS_layout/Flexbox_skills
Title: Test your skills: Flexbox
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
Title: Structuring a page of content
on GitHub

No new external URLs

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
Title: Marking up a letter
on GitHub

No new external URLs

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Test_your_skills:_HTML_text_basics
Title: Test your skills: HTML text basics
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Test_your_skills:_Advanced_HTML_text
Title: Test your skills: Advanced HTML text
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/Test_your_skills:_Links
Title: Test your skills: Links
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Tables/Structuring_planet_data
Title: Structuring planet data
on GitHub

No new external URLs

URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content/Test_your_skills:_Multimedia_and_embedding
Title: Test your skills: Multimedia and embedding
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding/Images_in_HTML/Test_your_skills:_HTML_images
Title: Test your skills: HTML images
on GitHub

https://codepen.io/ (2 times) (Note! This may be a new URL 👀)
https://glitch.com/ (2 times) (Note! This may be a new URL 👀)
https://jsfiddle.net/ (2 times) (Note! This may be a new URL 👀)

URL: /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
Title: Mozilla splash page
on GitHub

https://discourse.mozilla.org/c/mdn/learn/250 (1 time) (Note! This may be a new URL 👀)

(this comment was updated 2022-06-29 18:18:37.752482)

files/en-us/learn/css/building_blocks/a_cool_looking_box/index.md

estelle

Thank you.
Most of my edits are all the same: based on removing the e.g. My reasoning is on the last one.

files/en-us/learn/css/building_blocks/box_model_tasks/index.md

files/en-us/learn/css/building_blocks/cascade_tasks/index.md

files/en-us/learn/css/building_blocks/creating_fancy_letterheaded_paper/index.md

files/en-us/learn/css/building_blocks/fundamental_css_comprehension/index.md

files/en-us/learn/css/building_blocks/images_tasks/index.md

files/en-us/learn/html/introduction_to_html/structuring_a_page_of_content/index.md

files/en-us/learn/html/introduction_to_html/test_your_skills_colon__advanced_html_text/index.md

files/en-us/learn/html/introduction_to_html/test_your_skills_colon__html_text_basics/index.md

files/en-us/learn/html/introduction_to_html/test_your_skills_colon__links/index.md

files/en-us/learn/html/tables/structuring_planet_data/index.md

Co-authored-by: Estelle Weyl <[email protected]>

dipikabh · 2022-06-17T08:56:48Z

About the sentence:

"Details of what you have already tried, and what you would like us to do, e.g. if you are stuck and need help, or want an assessment."

I agree with @estelle that the two commas should go and that we should state the latter phrase as an example. My only nit is about how we state that example.

As per MDN's writing style guide, we should use contractions such as i.e. and e.g. inside parenthesis. I'm not sure how widely this guideline has been followed on MDN, but if we try to stick to this guideline in this instance, we can rephrase the sentence as:

"Details of what you have already tried and what you would like us to do; for example, tell us if you're stuck and need help or want an assessment."

glmvc · 2022-06-20T19:10:48Z

Hi @dipikabh, thanks for your input and suggestion, I think we should go with the sentence you suggested 🎉
Should we wait for @estelle's thoughts or can I start replacing the sentences?
Thank you in advance :)

estelle · 2022-06-27T16:55:43Z

Anything @dipikabh suggests is fine by me. She's an excellent tech editor!

glmvc · 2022-06-29T18:17:17Z

hey @dipikabh, I've changed the sentences according to your suggestion (HTML and CSS Learning Areas).

dipikabh

👍

glmvc · 2022-07-05T17:18:26Z

@estelle i think we are ready to merge :)

estelle

thank you!

Make "Assessment or further help" sections consistent

56f73b3

glmvc requested review from a team as code owners May 14, 2022 19:21

glmvc requested review from estelle and removed request for a team May 14, 2022 19:21

github-actions bot added the Content:Learn Learning area docs label May 14, 2022

glmvc mentioned this pull request Jun 7, 2022

Make Test your skills pages consistent #15579

Merged

3 tasks

estelle reviewed Jun 7, 2022

View reviewed changes

files/en-us/learn/css/building_blocks/a_cool_looking_box/index.md Outdated Show resolved Hide resolved

estelle and others added 2 commits June 7, 2022 11:19

Update files/en-us/learn/css/building_blocks/a_cool_looking_box/index.md

d76dc7b

Merge branch 'main' into patch-5

7c47e15

estelle requested changes Jun 13, 2022

View reviewed changes

glmvc and others added 3 commits June 14, 2022 21:17

Apply suggestions from code review

998726b

Co-authored-by: Estelle Weyl <[email protected]>

apply remaining suggestions from code review

1ab8b48

Merge branch 'main' into patch-5

af77ed6

glmvc requested a review from estelle June 14, 2022 19:55

glmvc and others added 3 commits June 29, 2022 20:04

adapt sentences according to suggestion

2f49ec1

Merge branch 'patch-5' of https://github.com/glmvc/content into patch-5

4fac926

Merge branch 'main' into patch-5

ac22bd7

dipikabh approved these changes Jul 5, 2022

View reviewed changes

estelle approved these changes Jul 11, 2022

View reviewed changes

estelle merged commit ace1400 into mdn:main Jul 11, 2022

glmvc deleted the patch-5 branch July 12, 2022 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make "Assessment or further help" sections consistent #16032

Make "Assessment or further help" sections consistent #16032

glmvc commented May 14, 2022

github-actions bot commented May 14, 2022 •

edited

Loading

estelle left a comment

dipikabh commented Jun 17, 2022

glmvc commented Jun 20, 2022

estelle commented Jun 27, 2022

glmvc commented Jun 29, 2022

dipikabh left a comment

glmvc commented Jul 5, 2022

estelle left a comment

Make "Assessment or further help" sections consistent #16032

Make "Assessment or further help" sections consistent #16032

Conversation

glmvc commented May 14, 2022

Summary

Motivation

Metadata

github-actions bot commented May 14, 2022 • edited Loading

Preview URLs

Flaws

External URLs

estelle left a comment

Choose a reason for hiding this comment

dipikabh commented Jun 17, 2022

glmvc commented Jun 20, 2022

estelle commented Jun 27, 2022

glmvc commented Jun 29, 2022

dipikabh left a comment

Choose a reason for hiding this comment

glmvc commented Jul 5, 2022

estelle left a comment

Choose a reason for hiding this comment

github-actions bot commented May 14, 2022 •

edited

Loading