Small tweaks to the Storage Access API data #21379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
|
FYI @tunetheweb |
tunetheweb
reviewed
Nov 28, 2023
api/Permissions.json
Outdated
| "chrome": { | ||
| "version_added": "119" | ||
| }, | ||
| "chrome_android": "mirror", |
There was a problem hiding this comment.
I had 120 for the storage-access permission on Android based on this so would be surprised if this did make it to 119. Might be worth double checking.
There was a problem hiding this comment.
OK. I've updated it for now, but we'll try to get it checked.
@cfredric, do you know what Chrome and Chrome Android versions the top-level-storage-access permission feature is supported from?
There was a problem hiding this comment.
The top-level-storage-access permission support in Chrome (tracked as requestStorageAccessFor) shipped alongside RWS, which was enabled by default in Chrome 119 (commit).
There was a problem hiding this comment.
Thanks! So the data as-is does sound about right.
Co-authored-by: Barry Pollard <[email protected]>
…browser-compat-data into moar-storage-access-api
Elchi3
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#21336 updated the Storage Access API compat data rather nicely. I created mdn/content#30500 to update the SAA docs and introduce the concept of related website sets to MDN, and in doing so, I found a couple of details I thought worth including in the BCD.
So, here goes.
Test results and supporting details
Related issues